Longan nano : a new gcc weird behaviour

 

This is a known quirk of recent compiler. 
It began with Arm, then appeared in apple llvm and now everywhere.
Can you see the error in the following code ? (answer at the end [1])

bool        myMcp23017::dumpRegisters()
{
uint8_t reg=0;
for(int i=0;i<27;i++)
   Logger("Reg 0x%x : 0x%x\n  ",i,reg);
}

The usual bug is there is a crash at returns because the return address is mixed-up.
On riscV, the generated code is as follows :

Dump of assembler code for function _ZN10myMcp2301713dumpRegistersEv:
0x08007f3e <+0>:     addi    sp,sp,-16
0x08007f40 <+2>:     sw      ra,12(sp)
0x08007f42 <+4>:     sw      s0,8(sp)
0x08007f44 <+6>:     sw      s1,4(sp)
0x08007f46 <+8>:     sw      s2,0(sp)
0x08007f48 <+10>:    li      s2,0
0x08007f4a <+12>:    li      s0,0
0x08007f4c <+14>:    lui     s1,0x8001
0x08007f50 <+18>:    mv      a2,s2
0x08007f52 <+20>:    mv      a1,s0
0x08007f54 <+22>:    addi    a0,s1,1608 # 0x8001648
0x08007f58 <+26>:    jal     ra,0x8001f48 <_Z6LoggerPKcz>
0x08007f5c <+30>:    addi    s0,s0,1
0x08007f5e <+32>:    j       0x8007f50 <_ZN10myMcp2301713dumpRegistersEv+18>

What is the problem ?
The comparison is completely missing !
So it will loop forever. 
Took me a while to understand it, as the effect of the mistake is not the usual one.


[1] return true/false is missing


Comments

Post a Comment

Popular posts from this blog

Component tester with STM32 : Part 1 ADC, Resistor

Image
I was always  fascinated by the so call "transistor testers" that identify and report pin out, features of pretty much whatever you throw at it. They are based on Atmel 328p chip, the same as arduino nano. So why not do the same thing with a STM32/Bluepill ? The STM32 is faster, has a better ADC accuracy, more memory, can do float etc... and is not more expensive. Warning : I'm doing this for fun & to learn, it might contain error & plain misunderstanding So, i watched a couple of video on the general principle on how they work. This is not a "port" but a rewrite from ~ scratch. When something is weird, i check what the original one does for comparison. Measuring resistance So first thing first :  Resistance & Capacitance. These 2 will unlock the other ones. So how do we measure resistance ? What we do is a resistor divider with a know resistance value: Measure = Vcc*(RtoTest/(RtoTest+Rknown)) As far as the ADC goes, it means ADC=...
Read more

Fixing the INA3221

Image
It 's not too complicated to change the board we have seen  previously . You 'll need to cut some tracks, i did it with a dremel and i'm not very handy, so you'll do better. Red =Cut tracks Blue = Add wire 1- You'll need to separate the bottom connector from the ground, cut the 3 connectors BOTH SIDES. 2- Remove the small red area below the middle resistor to isolate each channels from each other Last, connect right side of each connector to the now isolated pad. Mine looks like this after the operation (ugly i know): Be wary of the small track on the left connector that leads to the left side of channel3 resistor. I cut it while isolating the right pad. Now it works, we can go back to the charger.
Read more

INA3221, weird wiring

Image
Continuing my "smart" battery charger, i've finally received the INA3221 module. It is the purple one you can find on ebay for ~ 5 bucks I soldered a couple of pins to be able to connect it so that i could test it and something immediately caught my attention. It is supposed to be a high side current/voltage sensor, typically in a setup like that : So you can measure the voltage supplied to the load, and the current going through it. Now, let's have a look at the module, look at the top of the following pic, where the sense connectors are. CH3/GND/CH2/GND/CH1/GND ? Wait ? What ? Yes, all the IN- pins are connected to ground, so it is a bottom current only sensor. Additionally, the - side of the shunts are ALSO connected to the ground, no only the connectors. The actual layout is like that : That raises two problems :  The voltage is meaningless as we are only measuring Current x ShuntValue, not the supply volt...
Read more